fix(s3): preserve list version page missing-bucket errors#164
Open
fix(s3): preserve list version page missing-bucket errors#164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Follow-up coverage for the
ls --versionswork in #162.Background
The recent
ls --versionschange introducedS3Client::list_object_versions_pageto preserve pagination markers and delete markers for version listings. That helper is the behavior boundary the CLI now relies on.Root cause
The new helper had no direct regression coverage. When exercised against a
NoSuchBucketservice response, it still used the raw SDK display string for classification, which drops the AWS error code in this test harness and falls back toError::Generalinstead of the expectedError::NotFound.Solution
This change adds focused unit coverage for the version-listing page contract and aligns the helper with the existing S3 error formatting path. The new tests verify that the request carries the versions subresource, prefix, and max-keys parameters, that delete markers and pagination metadata are preserved, and that
NoSuchBucketmaps back to the bucket-not-found contract.Validation
cargo test -p rc-s3 list_object_versions_page --libcargo test -p rustfs-cli ls::tests --libmake pre-commit