test(s3): cover select empty error-code fallback#157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused regression coverage for one remaining S3 Select error-classification fallback path.
Recent test-gap work around
classify_aws_codealready covered missing-metadata fallbacks such asAccessDenied,NoSuchBucket,NotImplemented, andNoSuchKey. One small branch was still untested: when the SDK surfaces an empty error code string instead of omitting the metadata entirely. The runtime code intentionally treats an empty code the same as missing metadata by filtering it out before substring-based fallback classification.This patch adds a single unit test in
crates/s3/src/select.rsto lock that behavior in place. It does not change runtime logic.Root Cause
The fallback logic uses
code.filter(|s| !s.is_empty())before dispatching to the missing-metadata classifier, but the existing tests only exercisedNonemetadata and did not cover theSome("")case. That left a small but real compatibility path unverified.Validation
cargo test -p rc-s3 classify_empty_code_maps_access_denied_substring --libcargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacemake pre-commit