test(s3): cover select access denied fallback#153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
None. This is focused test-gap coverage from recent S3 Select work.
Background
Recent S3 Select support added error classification for backend failures. The mapper already handled explicit AccessDenied metadata, but the fallback path used when SDK metadata is missing did not preserve the auth classification.
Root Cause
classify_aws_code_missing_metadata only searched fallback error text for NotImplemented, NoSuchKey, and NoSuchBucket. AccessDenied text therefore fell through to a general error.
Solution
Add a focused fallback branch that maps AccessDenied text to rc_core::Error::Auth, plus a unit test covering the missing-metadata path.
Tests