test(cli): cover SQL Select parser options#148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Automated test-gap detection for the recent S3 Select command work.
Background
The recent SQL Select feature added a new top-level
rc sqlcommand with format and compression flags. Existing coverage included help output and early execution errors, while PR #147 covers S3 request serialization. The remaining gap was the root CLI parser path that binds user-provided SQL Select options intoSqlArgs.Solution
Add focused parser coverage for
rc sqlwith explicit JSON input/output and gzip compression, plus a defaults case for CSV input/output and no compression. This keeps the scope limited to command wiring and avoids duplicating the S3 serialization tests already covered elsewhere.Validation
cargo test -p rustfs-cli commands::tests::cli_accepts_sql --libmake pre-commit