Fix linking on i686 MSVC when using bare linkers by zanieb · Pull Request #242 · rust-secure-code/cargo-auditable

zanieb · 2026-03-04T14:34:17Z

I encountered the following failure downstream here when building for i686-pc-windows-msvc

error: linking with `link.exe` failed: exit code: 1120
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.44.35207\\bin\\HostX64\\x86\\link.exe" "/NOLOGO" "/LARGEADDRESSAWARE" "/SAFESEH" "<1 object files omitted>" "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcxUdZNX/{libsys_info-727445bcec1484dc,libgetrandom-03f1af69d8bb0dc3,libring-20e9f9b6bddfbf32,libzstd_sys-6f820048658e0218,liblzma_sys-5727454a96f1fe21,libbzip2_sys-042215639539600b,libwindows_registry-94186f962003b7ef,libwindows-b747ecf4d9ea130e,libwindows_core-c078246ff8b6d0f5,libwindows_strings-382cf632e8571ac4,libwindows_result-15d6e169fb672ecb,libgetrandom-80cc23cc52d9d4d6,libwindows_sys-8c7aed12b52cda18,liblibmimalloc_sys-9802f8e7d536448a,libstd-3c12ab3e8905162f}.rlib" "<sysroot>\\lib\\rustlib\\i686-pc-windows-msvc\\lib/libcompiler_builtins-*.rlib" "psapi.lib" "powrprof.lib" "advapi32.lib" "kernel32.lib" "ktmw32.lib" "user32.lib" "kernel32.lib" "bcrypt.lib" "advapi32.lib" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1949cf8c6b5b557f\\windows_i686_msvc-0.52.6\\lib\\windows.0.52.0.lib" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1949cf8c6b5b557f\\windows_i686_msvc-0.52.6\\lib\\windows.0.52.0.lib" "C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1949cf8c6b5b557f\\windows_i686_msvc-0.52.6\\lib\\windows.0.52.0.lib" "psapi.lib" "shell32.lib" "user32.lib" "advapi32.lib" "bcrypt.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "kernel32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "/NXCOMPAT" "/LIBPATH:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\bzip2-sys-5709dc9588ef4005\\out\\lib" "/LIBPATH:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\lzma-sys-47800abec4e5590e\\out" "/LIBPATH:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\zstd-sys-10b325c91fd2e25d\\out" "/LIBPATH:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\ring-2252f86e5b76bd21\\out" "/LIBPATH:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\sys-info-0c2f03090b39a83a\\out" "/LIBPATH:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\libmimalloc-sys-988de48ff381680c\\out" "/LIBPATH:C:\\Users\\runneradmin\\.cargo\\registry\\src\\index.crates.io-1949cf8c6b5b557f\\windows_i686_msvc-0.52.6\\lib" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.44.35207\\atlmfc\\lib\\x86" "/OUT:C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\deps\\uv.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/NATVIS:<sysroot>\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:<sysroot>\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:<sysroot>\\lib\\rustlib\\etc\\libcore.natvis" "/NATVIS:<sysroot>\\lib\\rustlib\\etc\\libstd.natvis" "/NATVIS:C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcxUdZNX\\uv-0.natvis" "/NATVIS:C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcxUdZNX\\uv-1.natvis" "/NATVIS:C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcxUdZNX\\uv-2.natvis" "/MANIFEST:EMBED" "/MANIFESTINPUT:\\\\?\\C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\build\\uv-020ed9adf36b91fe\\out\\manifest.xml" "/MANIFESTUAC:NO" "C:\\a\\uv\\uv\\target\\i686-pc-windows-msvc\\release\\deps\\uv_audit_data.o" "/INCLUDE:AUDITABLE_VERSION_INFO"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: LINK : error LNK2001: unresolved external symbol AUDITABLE_VERSION_INFO␍
          C:\a\uv\uv\target\i686-pc-windows-msvc\release\deps\uv.exe : fatal error LNK1120: 1 unresolved externals␍

I then used an LLM to debug this as I frankly don't know anything about symbol mangling on 32-bit Windows. The diagnosis seems plausible however, and this resolved the build failure.

Edit:

The specific error above was resolved by #245

This now fixes

error: could not compile `bare_linker` (bin "bare_linker") due to 1 previous error
{"reason":"compiler-message","package_id":"path+file:///D:/a/cargo-auditable/cargo-auditable/cargo-auditable/tests/fixtures/bare_linker#0.1.0","manifest_path":"D:\\a\\cargo-auditable\\cargo-auditable\\cargo-auditable\\tests\\fixtures\\bare_linker\\Cargo.toml","target":{"kind":["bin"],"crate_types":["bin"],"name":"bare_linker","src_path":"D:\\a\\cargo-auditable\\cargo-auditable\\cargo-auditable\\tests\\fixtures\\bare_linker\\src\\main.rs","edition":"2024","doc":true,"doctest":false,"test":true},"message":{"rendered":"error: linking with `rust-lld` failed: exit code: 1\n  |\n  = note: \"rust-lld\" \"-flavor\" \"gnu\" \"--dynamicbase\" \"--disable-auto-image-base\" \"-m\" \"i386pep\" \"--high-entropy-va\" \"C:\\\\Users\\\\RUNNER~1\\\\AppData\\\\Local\\\\Temp\\\\rustcOHQo9S\\\\symbols.o\" \"<2 object files omitted>\" \"-Bstatic\" \"<sysroot>\\\\lib\\\\rustlib\\\\x86_64-pc-windows-gnu\\\\lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,libwindows_targets-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib\" \"-Bdynamic\" \"-lkernel32\" \"-lkernel32\" \"-lkernel32\" \"-lntdll\" \"-luserenv\" \"-lws2_32\" \"-ldbghelp\" \"-lgcc_eh\" \"-l:libpthread.a\" \"-lmsvcrt\" \"-lmingwex\" \"-lmingw32\" \"-lgcc\" \"-lmsvcrt\" \"-lmingwex\" \"-luser32\" \"-lkernel32\" \"--nxcompat\" \"-o\" \"D:\\\\a\\\\cargo-auditable\\\\cargo-auditable\\\\cargo-auditable\\\\tests\\\\fixtures\\\\bare_linker\\\\target\\\\x86_64-pc-windows-gnu\\\\release\\\\deps\\\\bare_linker-c1af179e99ffbe38.exe\" \"--gc-sections\" \"-O1\" \"--strip-debug\" \"D:\\\\a\\\\cargo-auditable\\\\cargo-auditable\\\\cargo-auditable\\\\tests\\\\fixtures\\\\bare_linker\\\\target\\\\x86_64-pc-windows-gnu\\\\release\\\\deps\\\\bare_linker_audit_data.o\" \"-u\" \"AUDITABLE_VERSION_INFO\"\n  = note: some arguments are omitted. use `--verbose` to show all linker arguments\n  = note: lld: error: unable to find library -lkernel32␍\n          lld: error: unable to find library -lkernel32␍\n          lld: error: unable to find library -lkernel32␍\n          lld: error: unable to find library -lntdll␍\n          lld: error: unable to find library -luserenv␍\n          lld: error: unable to find library -lws2_32␍\n          lld: error: unable to find library -ldbghelp␍\n          lld: error: unable to find library -lgcc_eh␍\n          lld: error: unable to find library -l:libpthread.a␍\n          lld: error: unable to find library -lmsvcrt␍\n          lld: error: unable to find library -lmingwex␍\n          lld: error: unable to find library -lmingw32␍\n          lld: error: unable to find library -lgcc␍\n          lld: error: unable to find library -lmsvcrt␍\n          lld: error: unable to find library -lmingwex␍\n          lld: error: unable to find library -luser32␍\n          lld: error: unable to find library -lkernel32␍\n          \n\n","$message_type":"diagnostic","children":[{"children":[],"code":null,"level":"note","message":"\"rust-lld\" \"-flavor\" \"gnu\" \"--dynamicbase\" \"--disable-auto-image-base\" \"-m\" \"i386pep\" \"--high-entropy-va\" \"C:\\\\Users\\\\RUNNER~1\\\\AppData\\\\Local\\\\Temp\\\\rustcOHQo9S\\\\symbols.o\" \"<2 object files omitted>\" \"-Bstatic\" \"<sysroot>\\\\lib\\\\rustlib\\\\x86_64-pc-windows-gnu\\\\lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,libwindows_targets-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib\" \"-Bdynamic\" \"-lkernel32\" \"-lkernel32\" \"-lkernel32\" \"-lntdll\" \"-luserenv\" \"-lws2_32\" \"-ldbghelp\" \"-lgcc_eh\" \"-l:libpthread.a\" \"-lmsvcrt\" \"-lmingwex\" \"-lmingw32\" \"-lgcc\" \"-lmsvcrt\" \"-lmingwex\" \"-luser32\" \"-lkernel32\" \"--nxcompat\" \"-o\" \"D:\\\\a\\\\cargo-auditable\\\\cargo-auditable\\\\cargo-auditable\\\\tests\\\\fixtures\\\\bare_linker\\\\target\\\\x86_64-pc-windows-gnu\\\\release\\\\deps\\\\bare_linker-c1af179e99ffbe38.exe\" \"--gc-sections\" \"-O1\" \"--strip-debug\" \"D:\\\\a\\\\cargo-auditable\\\\cargo-auditable\\\\cargo-auditable\\\\tests\\\\fixtures\\\\bare_linker\\\\target\\\\x86_64-pc-windows-gnu\\\\release\\\\deps\\\\bare_linker_audit_data.o\" \"-u\" \"AUDITABLE_VERSION_INFO\"","rendered":null,"spans":[]},{"children":[],"code":null,"level":"note","message":"some arguments are omitted. use `--verbose` to show all linker arguments","rendered":null,"spans":[]},{"children":[],"code":null,"level":"note","message":"lld: error: unable to find library -lkernel32\r\nlld: error: unable to find library -lkernel32\r\nlld: error: unable to find library -lkernel32\r\nlld: error: unable to find library -lntdll\r\nlld: error: unable to find library -luserenv\r\nlld: error: unable to find library -lws2_32\r\nlld: error: unable to find library -ldbghelp\r\nlld: error: unable to find library -lgcc_eh\r\nlld: error: unable to find library -l:libpthread.a\r\nlld: error: unable to find library -lmsvcrt\r\nlld: error: unable to find library -lmingwex\r\nlld: error: unable to find library -lmingw32\r\nlld: error: unable to find library -lgcc\r\nlld: error: unable to find library -lmsvcrt\r\nlld: error: unable to find library -lmingwex\r\nlld: error: unable to find library -luser32\r\nlld: error: unable to find library -lkernel32\r\n","rendered":null,"spans":[]}],"level":"error","message":"linking with `rust-lld` failed: exit code: 1","spans":[],"code":null}}

from https://github.com/rust-secure-code/cargo-auditable/actions/runs/22680924943/job/65750878044

Shnatsel

I'll add 32-bit Windows CI job in a separate PR. Hopefully I can verify that it fails and that this PR fixes it. I don't really want to repeat #240 even though nobody complained.

cargo-auditable/src/platform_detection.rs

cargo-auditable/src/rustc_wrapper.rs

Shnatsel · 2026-03-04T15:17:28Z

cargo-auditable/src/object_file.rs

+        let mut feature: u64 = 0;
+        if architecture == Architecture::I386 {
+            feature |= 1; // IMAGE_FILE_SAFE_EXCEPTION_HANDLER
+        }
+        file.add_symbol(Symbol {
+            name: b"@feat.00".to_vec(),
+            value: feature,
+            size: 0,
+            kind: SymbolKind::Data,
+            scope: SymbolScope::Compilation,
+            weak: false,
+            section: SymbolSection::Absolute,
+            flags: SymbolFlags::None,
+        });


I don't really know much about the implications of some fields, such as the file.add_symbol call and all its arguments. Is this referenced from somewhere? It would be nice to have a comment explaining this.

Indeed the relevant reference is https://github.com/rust-lang/rust/blob/b90dc1e597db0bbc0cab0eccb39747b1a9d7e607/compiler/rustc_codegen_ssa/src/back/metadata.rs#L224-L252

I'll add a link in a comment.

cargo-auditable/src/object_file.rs

Shnatsel · 2026-03-04T17:16:18Z

This did make bare linker work on Windows while #245 does not. CI on #243 shows it clearly.

So I'm happy to merge the remaining changes.

zanieb · 2026-03-04T17:43:30Z

I'm happy to make more changes but also feel free to push any further tweaks to the commentary directly.

Shnatsel · 2026-03-04T18:40:47Z

Thanks! I'll take another look later today and hopefully publish a release with the fix by tomorrow.

zanieb force-pushed the zb/i686-win branch from 832ef75 to afee545 Compare March 4, 2026 14:36

zanieb changed the title ~~Fix 32-bit MSVC linking~~ Fix i686 MSVC linking Mar 4, 2026

Shnatsel reviewed Mar 4, 2026

View reviewed changes

Shnatsel mentioned this pull request Mar 4, 2026

I686 tests plus fix #244

Closed

zanieb mentioned this pull request Mar 4, 2026

Fix i686 MSVC linking by handling name mangling #245

Merged

Fix linking on i686 MSVC when using bare linkers

9c77687

zanieb force-pushed the zb/i686-win branch from afee545 to 9c77687 Compare March 4, 2026 17:42

zanieb changed the title ~~Fix i686 MSVC linking~~ Fix linking on i686 MSVC when using bare linkers Mar 4, 2026

Shnatsel mentioned this pull request Mar 4, 2026

Windows bare linker tests with fix #247

Closed

Shnatsel merged commit 66bb33f into rust-secure-code:master Mar 4, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix linking on i686 MSVC when using bare linkers#242

Fix linking on i686 MSVC when using bare linkers#242
Shnatsel merged 1 commit intorust-secure-code:masterfrom
zanieb:zb/i686-win

zanieb commented Mar 4, 2026 •

edited

Loading

Uh oh!

Shnatsel left a comment

Uh oh!

Uh oh!

Uh oh!

Shnatsel Mar 4, 2026

Uh oh!

zanieb Mar 4, 2026

Uh oh!

Uh oh!

Shnatsel commented Mar 4, 2026

Uh oh!

zanieb commented Mar 4, 2026

Uh oh!

Shnatsel commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zanieb commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shnatsel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Shnatsel Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

zanieb Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shnatsel commented Mar 4, 2026

Uh oh!

zanieb commented Mar 4, 2026

Uh oh!

Shnatsel commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zanieb commented Mar 4, 2026 •

edited

Loading