Expose data for custom boot image creation#535
Conversation
Freax13
left a comment
Freax13
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Sorry for the delay.
I'm not too sure about this. AFAICT the newly exposed APIs are primarily meant for expert users who want to have more control over the disk images. I'd expect that such users are capable of creating FAT images themselves (and probably prefer to do so), so I'm not sure how much of a help the new functions are.
Wasabi375
force-pushed
the
disk_image
branch
from
76a4cd7 to
2824a46
Compare
|
Tbh I can't really explain what I was thinking when I exposed the bios side as The uefi side is less of an issue as uefi is contained in a single binary as you pointed out.
Yeah no worries. Sometimes life gets in the way and I don't think anyone has a right to your time. As you can see I got distracted by life myself so I totally understand 😉 |
Wasabi375
force-pushed
the
disk_image
branch
from
2824a46 to
06f5949
Compare
2 participants
Right now it is difficult to use this bootloader with more than just the basic disk-images create by this crate, e.g. it is currently not possible to create a boot-image with multiple partitions.
It can be achieved but that requires a somewhat complex build script that installs "bootloader-x86_64-uefi" or the bios variants and then creates the fat-partition by hand.
This change exposes some functionality of
DiskImageBuilderto make some of those things easier.The
bootloadercrate already has a buildscript that installs the necessary uefi/bios creates and extracts those files into byte arrays. Those are now public.I also extracted the functionality to create a boot-able FAT-partition into it's own function and marked it as pub.
The goal of this PR is not to create a fully configurable system to add partitions to the boot image, but to expose the necessary data, for consumer of this crate to build their own partitioning scheme.