Use contribute_arg to handle NoCurrentOp at the top-level#293
Open
IsaacWoods wants to merge 1 commit intorust-osdev:mainfrom
Open
Use contribute_arg to handle NoCurrentOp at the top-level#293IsaacWoods wants to merge 1 commit intorust-osdev:mainfrom
contribute_arg to handle NoCurrentOp at the top-level#293IsaacWoods wants to merge 1 commit intorust-osdev:mainfrom
Conversation
This makes our arg contribution code more uniform, and as a benefit gracefully handles incorrect `Zero` and `One` (as well as other, in theory` opcodes at the top-level. This pattern is seen in the wild fairly often.
Contributor
|
Looks good to me - tested and fixes the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes our arg contribution code more uniform, and as a benefit gracefully handles incorrect
ZeroandOne(as well as other, in theory` opcodes at the top-level. This pattern is seen in the wild fairly often.Fix #289