Closed
Conversation
Author
No problem, can update with unit tests, and try my hand at some doc-examples :)
Didn't mean to step on any toes. Will definitely close, and give preference to @vks over this PR. Just wasn't sure if #10 was still relevant, since similar code exists in |
Author
|
@cuviper I added the requested changes, let me know what you think. Will squash the fixup, if you approve. |
Contributor
|
I will update my PR this week.
…On Mon, Jan 18, 2021, 21:05 Nym Seddon ***@***.***> wrote:
@cuviper <https://github.com/cuviper> I added the requested changes, let
me know what you think. Will squash the fixup, if you approve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIFNF77J5Q7KWFNUICXHTS2SH63ANCNFSM4VM42JAA>
.
|
Author
|
Closing in favor of an updated #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.