Added eigg function which is a wrapper to ggev#280
Open
selvavm wants to merge 1 commit intorust-ndarray:masterfrom
Open
Added eigg function which is a wrapper to ggev#280selvavm wants to merge 1 commit intorust-ndarray:masterfrom
selvavm wants to merge 1 commit intorust-ndarray:masterfrom
Conversation
Added doc comments for eigg function Added testcase
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
=========================================
Coverage ? 88.86%
=========================================
Files ? 71
Lines ? 3727
Branches ? 0
=========================================
Hits ? 3312
Misses ? 415
Partials ? 0
Continue to review full report at Codecov.
|
Author
|
@termoshtt - could you please review this? |
Author
|
@termoshtt - I noticed that I can change my implementation to be consistent with it. That is change mine to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #267. It is equivalent of
eig(A,B)in Matlab