Skip to content

Split target_os = "nto" cfg by env so io-sock variants use TCP_KEEPIDLE #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thomasdezeeuw merged 3 commits into from
May 5, 2026
+2 −2
Merged

Split target_os = "nto" cfg by env so io-sock variants use TCP_KEEPIDLE #654

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b350b54
Split target_os = "nto" cfg by env so io-sock variants use TCP_KEEPIDLE
skarlsson May 2, 2026
69b5c3e
removed comments
skarlsson May 4, 2026
7609a30
Apply cargo fmt to nto cfg predicates
skarlsson May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sys/unix.rs
View file
Open in desktop
Copy link
Copy Markdown
Member

@Darksonn Darksonn May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the new QNX versions to CI so we actually build this stuff?

socket2/.github/workflows/main.yml

Lines 67 to 111 in 602e784

target:
- aarch64-apple-darwin
- aarch64-apple-ios
- aarch64-apple-tvos
- aarch64-apple-visionos
- aarch64-apple-watchos
- aarch64-linux-android
- aarch64-unknown-freebsd
- aarch64-unknown-linux-gnu
- aarch64-unknown-linux-musl
- aarch64-unknown-linux-ohos
- aarch64-unknown-netbsd
- aarch64-unknown-openbsd
- aarch64-unknown-redox
- arm-linux-androideabi
- arm64_32-apple-watchos
- armv7-linux-androideabi
- armv7-sony-vita-newlibeabihf
- armv7-unknown-linux-ohos
- i686-linux-android
# Broken, see https://github.com/rust-lang/socket2/issues/539.
#- i686-unknown-hurd-gnu
- i686-unknown-linux-gnu
- sparcv9-sun-solaris
- x86_64-apple-darwin
- x86_64-apple-ios
- x86_64-pc-cygwin
- x86_64-pc-solaris
# Fails with:
# `rror calling dlltool 'x86_64-w64-mingw32-dlltool': No such file or
# directory (os error 2)`, build log:
# <https://github.com/rust-lang/socket2/actions/runs/9577808331/job/26406752150>.
#- x86_64-pc-windows-gnu
- x86_64-pc-windows-msvc
- x86_64-unknown-dragonfly
- x86_64-unknown-freebsd
- x86_64-unknown-fuchsia
- x86_64-unknown-illumos
- x86_64-unknown-linux-gnu
- x86_64-unknown-linux-musl
- x86_64-unknown-linux-ohos
- x86_64-unknown-netbsd
- x86_64-unknown-openbsd
- x86_64-unknown-redox
- wasm32-wasip2

Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ pub(crate) type Bool = c_int;
target_os = "ios",
target_os = "visionos",
target_os = "macos",
target_os = "nto",
all(target_os = "nto", any(target_env = "nto70", target_env = "nto71"),),
target_os = "tvos",
target_os = "watchos",
))]
Expand All @@ -312,7 +312,7 @@ use libc::TCP_KEEPALIVE as KEEPALIVE_TIME;
target_os = "ios",
target_os = "visionos",
target_os = "macos",
target_os = "nto",
all(target_os = "nto", any(target_env = "nto70", target_env = "nto71"),),
target_os = "openbsd",
target_os = "tvos",
target_os = "watchos",
Expand Down
Loading