rustc_on_unimplemented: introduce format specifiers#156161
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. Some changes occurred in compiler/rustc_hir/src/attrs |
rustbot
added
A-attributes
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
mejrs
removed
the
T-libs
This comment has been minimized.
This comment has been minimized.
…ns for the annotated item.
Contributor
Author
|
r? compiler |
oli-obk
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
@bors r+
since this seems to be a multi-step undertaking, please add a tracking issue and link to it from every PR that makes progress on it
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
@bors rollup |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 26, 2026
…uwer Rollup of 9 pull requests Successful merges: - #156959 (stdarch subtree update) - #156541 (delegation: remove method call generation) - #156161 (rustc_on_unimplemented: introduce format specifiers) - #156752 (fix E0371 description) - #156761 (tidy: remove duplicate entry and alphabetize OS constants list) - #156872 (Drop skip_move_check_fns query.) - #156899 (fix breakpoint callback registration in `lldb_batchmode`) - #156927 (Reorganize `tests/ui/issues` [1/N]) - #156947 (Update mdbook to 0.5.3)
rust-timer
added a commit
that referenced
this pull request
May 26, 2026
Rollup merge of #156161 - mejrs:this_formatargs, r=oli-obk rustc_on_unimplemented: introduce format specifiers ...as printing options for the annotated item. See also the test and dev guide prose. This only affects rustc_on_unimplemented, not (yet) the other diagnostic attributes. I plan to do that in some later PR. ```rust #![feature(rustc_attrs)] #[rustc_on_unimplemented( message = "normal: {This}, path: {This:path}, resolved: {This:resolved}" )] pub trait Trait<'lifetime, const CONST_GENERIC: usize, A, B> where A: Send {} ``` will do: ``` normal: Trait, path: Trait<'lifetime, CONST_GENERIC, A, B>, resolved: Trait<'_, 6, u8, _> ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...as printing options for the annotated item.
See also the test and dev guide prose. This only affects rustc_on_unimplemented, not (yet) the other diagnostic attributes. I plan to do that in some later PR.
will do: