l4re: change bit widths of file offset types#5173
Conversation
rustbot
added
S-waiting-on-review
stable-nominated
dybucc
force-pushed
the
l4re-file-offsets
branch
from
a64dd66 to
66c2f42
Compare
dybucc
changed the title
dybucc
force-pushed
the
l4re-file-offsets
branch
from
66c2f42 to
244c00b
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
changed the title
dybucc
force-pushed
the
l4re-file-offsets
branch
from
244c00b to
f0bf0bf
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
force-pushed
the
l4re-file-offsets
branch
2 times, most recently
from
caac209 to
e16db76
Compare
|
I'm pretty fine deprecating these since the platform has pretty low use, but we should figure out the other uclibc PR first. @SnoozeThis #5165 -> remove label S-blocked, add label S-waiting-on-review |
|
(https://snoozeth.is/u1Hjq3aITKU) I will wait until #5165 is merged and then add label S-waiting-on-review and remove label S-blocked. @rustbot claim. |
| #[deprecated( | ||
| since = "0.2.187", | ||
| note = "Use `fsblkcnt_t` instead. The unsuffixed type is defined in terms of the suffixed type \ | ||
| upstream under the current target architecture (x86_64,) and support for suffixed \ | ||
| types is phasing out in the `libc` crate." | ||
| )] | ||
| pub type fsblkcnt64_t = c_ulong; |
There was a problem hiding this comment.
The arch is wrong here but these deprecation messages are more complicated than needed anyway. Let's keep things simple and point elsewhere if more info is required, e.g.:
Use
fsblkcnt_tinstead. LFS64 aliases are being phased out, see #4805.
There was a problem hiding this comment.
Done. What do you mean by "the arch is wrong here?" There's no supported Rust target using AArch64, L4Re and uClibc. Should I remove the whole module?
There was a problem hiding this comment.
Originally it said "under the current target architecture (x86_64,)", but this was in the aarch64 module
dybucc
force-pushed
the
l4re-file-offsets
branch
from
e16db76 to
0c5f454
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
force-pushed
the
l4re-file-offsets
branch
2 times, most recently
from
e1d5fdc to
fb8fb9e
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
force-pushed
the
l4re-file-offsets
branch
from
fb8fb9e to
a2d1a13
Compare
Add deprecation warnings to LFS64 bindings under L4Re uClibc. This patch adds notices to types and routines. The only supported target is 64-bits wide. Its suffixed and unsuffixed types should always be equivalent.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
dybucc
force-pushed
the
l4re-file-offsets
branch
from
a2d1a13 to
e09560e
Compare
|
@rustbot blocked |
4 participants
Description
This PR deprecates a number of symbols from the
unix/linux_like/l4remodule. This has also come with further deprecations and modifications in other top-level modules.At present, the definitions in upstream l4re-core are always 64-bit wide for the 64-bit targets we seem to support in this module. Though rustc only has support for x86_64 under this target OS.
Sources
Sources on the uClibc changes are documented in #5165. A regex search of the affected symbols on l4re-core's
libcdirectory reveals no modifications in their patches would necessitate changes in this patch.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated