Open
Conversation
Member
Author
|
Converted to draft, this needs to be updated. See #121 (comment) |
jannic
force-pushed
the
unaligned-heap-workaround
branch
from
fa56613 to
65df6d7
Compare
jannic
changed the title
therealprof
reviewed
Feb 3, 2026
thejpster
reviewed
Feb 3, 2026
thejpster
reviewed
Feb 5, 2026
zeenix
reviewed
Feb 6, 2026
thejpster
approved these changes
Feb 6, 2026
Contributor
thejpster
left a comment
thejpster
left a comment
There was a problem hiding this comment.
I agree with Zeenix, otherwise LGTM
jonathanpallant
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save the value returned from
insert_free_block_ptrso infree_with_cs, the call toiter_blocksuses correct values.Fixes #121
Also fixes the issue regarding too small heaps mentioned in #119 (comment)