Conversation
pyk run retains the <generatedCounter> cell that Java krun strips. Update .out files where the only difference from the old baseline is the addition of the <generatedCounter> cell at the end of the <generatedTop> configuration. Affected tests: context-alias (2, 2b, 4, 4b, 5, 6, 6b, 8, 8b) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pyk run formats multi-step K-sequences with each ~>-separated item on its own line, where Java krun collapses them to a single line. Update .out files where this formatting difference (alongside generatedTop/generatedCounter) changed the baseline. Affected tests: context-alias (1, 1b, 3, 3b, 5b, 7, 7b, 9, 10), issue-1263 (1), issue-1528 (1, 2, 3), or-llvm (4, 5) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pyk run formats List/Map collection items inline (space-separated), where Java krun puts each item on its own line. Update .out files where this formatting difference (alongside generatedTop/generatedCounter) changed the baseline. Affected tests: rand (1), rangemap-tests-llvm (20 cases) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…m, rand, rangemap-tests-llvm All six tests now pass with updated baselines that reflect pyk's output format (generatedTop/generatedCounter cells present, K-sequence items on separate lines, collection items inline). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mark Category G resolved (6 tests un-skipped via baseline updates). Update Category F to show --top-cell was added and issue-2075-2 un-skipped, and clarify secondary blockers for remaining 3 tests. Update summary table with current counts and status. Update Category J to note configuration-formatting and pattern-macro are now Category G-style quick wins (update-results). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ehildenb
commented
Apr 27, 2026
Comment on lines
-3
to
+4
| 2 ~> test ( bar ~> .K ) ~> .K | ||
| 2 | ||
| ~> test ( bar ~> .K ) |
Member
Author
There was a problem hiding this comment.
This change is a bit weird, but I would let it be. Looks like in our printer we are special-casing k-sequences directly below the <k> cell.
Member
Author
|
MacOS tests are failing because of runner issues, will get them sorted. |
tothtamas28
reviewed
Apr 29, 2026
| </k> | ||
| <generatedTop> | ||
| <k> | ||
| [ 1 , 2 ) r|-> 45 [ 2 , 5 ) r|-> 40 ~> .K |
Contributor
There was a problem hiding this comment.
Empty K-sequence is not printed at the end of K-sequence on the
<k>cell.
This doesn't seem to be enforced consistently.
Can we change the pyk printer to just print the .K in all cases? That would make the output more predictable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To start from a clean baseline while reimplementing the kompile pipeline in pyk, this updates the test expected output and uncomments some tests that are passing with the updated output. The main changes in the pyk printer from the Java one are:
~>is displayed with newlines.<k>cell.<generatedCounter>and<generatedTop>) are not omitted.The documentation file is also updated (by Claude) to reflect the current triage status of the regression-new test-suite (at
pyk/docs/regression-triage.md).