perf: drop lodash, cache publicPath regex, avoid forEach closure and double html scan#59
Open
arturovt wants to merge 1 commit intorunjuu:masterfrom
Open
perf: drop lodash, cache publicPath regex, avoid forEach closure and double html scan#59arturovt wants to merge 1 commit intorunjuu:masterfrom
arturovt wants to merge 1 commit intorunjuu:masterfrom
Conversation
…double html scan Replace lodash escapeRegExp with an inline implementation to remove the runtime dependency. Cache compiled publicPath RegExp instances per unique path instead of rebuilding on every getCSSStyle call. Switch forEach to for...of in prepare() to avoid closure allocation per asset. Replace the indexOf + replace double-pass in processStyle with a single replace(), detecting a missing target by comparing the result to the original string. Also convert replaceConfig and styleTagFactory from getters to constructor-assigned readonly fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace lodash escapeRegExp with an inline implementation to remove the runtime dependency. Cache compiled publicPath RegExp instances per unique path instead of rebuilding on every getCSSStyle call. Switch forEach to for...of in prepare() to avoid closure allocation per asset. Replace the indexOf + replace double-pass in processStyle with a single replace(), detecting a missing target by comparing the result to the original string.
Also convert replaceConfig and styleTagFactory from getters to constructor-assigned readonly fields.