Itemizable checks if the storage location changes, and updates inventory #5481
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5476
Description
I've updated the conditional logic in the
callmethod ofItemizableUpdateServiceto detect changes instorage_location_id.Previously, the service only published a new event if the quantities of items changed (
inventory_changes?). Now, it also publishes an event if the storage location has changed, ensuring the Inventory Aggregate correctly moves items from the old location to the new one.Type of change
How Has This Been Tested?
I've added a new test case:
"should send an event when the storage location changes".Donationand publish its initial event.ItemizableUpdateServicewith parameters that change thestorage_location_idbut keep the item quantities exactly the same.Screenshots
Previously, changing locations (Bulk Storage in this example) would not trigger an update on the inventory page. Now that same action updates to show the correct location
Before:


After:
