HOLD UNTIL READY TO LAUNCH: Allow authenticated users to access the people index and search#1494
Draft
maebeale wants to merge 1 commit into
Draft
HOLD UNTIL READY TO LAUNCH: Allow authenticated users to access the people index and search#1494maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
3 tasks
Open up the People index and people typeahead search to all authenticated users (previously admin-only). Show, edit, update, destroy remain admin-only. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
42ab70f to
9dbb9c9
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
GET /people) and people typeahead search to all authenticated usersHow did you approach the change?
PersonPolicy#index?andPersonPolicy#search?now allow any authenticated user instead of only adminsrelation_scopealready filters tosearchablepeople with active affiliations, so non-admins still don't see opted-out profiles or people with no active affiliationshow?,edit?,update?, anddestroy?remain admin-only (or owner forshow?)PersonPolicyspec so a regular user is expected to be allowed:index?/peopleUI Testing Checklist
/people, confirm the index loads (200)show/edit/updatepages unless they own them/search?model=person&q=...) returns results for a regular userAnything else to add?