Skip to content

Remove obsolete WASI Node flag #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ledsun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove obsolete WASI Node flag #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/cheat_sheet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ const { vm } = await DefaultRubyVM(module);
vm.eval(`puts "hello world"`);
```

Then run the example code with `--experimental-wasi-unstable-preview1` flag to enable WASI support:
Then run the example code:

```console
$ node --experimental-wasi-unstable-preview1 index.mjs
$ node index.mjs
```

## Browser
Expand Down
2 changes: 1 addition & 1 deletion packages/npm-packages/ruby-wasm-wasi/example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ $ # Open http://localhost:8000/script-src

```console
$ npm install
$ node --experimental-wasi-unstable-preview1 index.node.js
$ node index.node.js
```
2 changes: 1 addition & 1 deletion packages/npm-packages/ruby-wasm-wasi/example/index.node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import fs from "fs/promises";
import { DefaultRubyVM } from "@ruby/wasm-wasi/dist/node";

// $ node --experimental-wasi-unstable-preview1 index.node.js
// $ node index.node.js

const main = async () => {
const binary = await fs.readFile(
Expand Down
2 changes: 1 addition & 1 deletion packages/npm-packages/ruby-wasm-wasi/tools/run-test-unit.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh
":" //# ; exec /usr/bin/env node --experimental-wasi-unstable-preview1 "$0" "$@"
":" //# ; exec /usr/bin/env node "$0" "$@"

import * as browserWasi from "@bjorn3/browser_wasi_shim";
import * as preview2Shim from "@bytecodealliance/preview2-shim"
Expand Down
2 changes: 1 addition & 1 deletion packages/npm-packages/ruby-wasm-wasi/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default defineConfig({
pool: "forks",
poolOptions: {
forks: {
execArgv: ["--experimental-wasi-unstable-preview1", "--expose-gc"],
execArgv: ["--expose-gc"],
}
},
testTimeout: 300000,
Expand Down
Loading