Conversation
Collaborator
|
🚀 Preview deployment available at: https://55e27193.rdoc-6cd.pages.dev (commit: b3cf697) |
st0012
force-pushed
the
fix-server-ctrl-c
branch
from
aba78d5 to
7286f8e
Compare
The INT/TERM trap handler called shutdown, which closed the TCP server socket from the same thread blocked on accept, causing a ThreadError (deadlock; recursive locking). Replace the trap-based shutdown with rescue Interrupt around the accept loop. Move cleanup into an ensure block so it runs on any exit path.
st0012
force-pushed
the
fix-server-ctrl-c
branch
from
7286f8e to
b3cf697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rdoc --serverraisedThreadError: deadlock; recursive lockingbecause theINTtrap calledshutdown, which closed the TCP server socket from the same thread blocked onacceptrescue Interruptaround the accept loop, and move cleanup into anensureblock