✨ Support BINARY extention to #append (RFC3516) #616
Open
Conversation
`Net::IMAP::Literal` is currently only used by `#append` and `#id`, but more code will be refactored to use it in the (near?) future.
This adds the ability to send binary `literal8`, which were already supported by the parser for `FETCH`, and automatically uses `literal8` when the `#append` message includes `NULL` bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to send binary
literal8(which were already supported by the parser for#fetchand#uid_fetch) and automatically usesliteral8when the#appendmessage includesNULLbytes.This does not check the server's capabilities. Users still need to check the capabilities themselves, and servers that don't support
BINARYshould refuse the binary literal continuation request (withNO).This also validates that
Net::IMAP::Literaldoesn't containNULLbytes. It's currently only used by#appendand#id, but more code will be refactored to use it in the (near?) future.