Handle IO::TimeoutError during connection setup on Ruby 4.0#444
Open
k-tsuchiya-jp wants to merge 2 commits intoruby-ldap:masterfrom
Open
Handle IO::TimeoutError during connection setup on Ruby 4.0#444k-tsuchiya-jp wants to merge 2 commits intoruby-ldap:masterfrom
k-tsuchiya-jp wants to merge 2 commits intoruby-ldap:masterfrom
Conversation
Add a Ruby 4.0+ unit test to ensure Connection#socket wraps IO::TimeoutError as Net::LDAP::Error. Introduce FakeTCPSocket to raise dotted exception constants and capture stderr in the test.
Ruby 4.0 can raise IO::TimeoutError from socket connection code. Add IO::TimeoutError to the rescued exceptions so it is handled as a connection failure and reported via ConnectionError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IO::TimeoutErroras a connection setup failure and include itin aggregated
ConnectionErrorhandling.Connection#socketcorrectly wraps
IO::TimeoutErrorasNet::LDAP::Error.Why this is needed
Ruby 4.0 changed socket timeout behavior and may raise
IO::TimeoutErrorduring connection attempts. Previously, thisexception was not explicitly handled and could leak out instead of
being reported as a connection failure.
This PR aligns
IO::TimeoutErrorhandling with other socket-relatederrors (e.g.
SocketError,SystemCallError) and adds test coverageto prevent regressions.
The issue was originally reported in:
#442
Compatibility note
IO::TimeoutErrordoes not exist in Ruby 3.0 or 3.1.This PR does not change the support policy for those versions;
it only adds handling and test coverage for Ruby versions where
the exception is available.