Ability to add socket_class while instantiating net_ldap connection#356
Ability to add socket_class while instantiating net_ldap connection#356dhivyada wants to merge 1 commit intoruby-ldap:masterfrom
Conversation
mddelk
left a comment
mddelk
left a comment
There was a problem hiding this comment.
net-ldap-0.16.2.gem was accidentally committed
|
Removed the accidentally committed gem. Thank you for the feedback |
dhivyada
force-pushed
the
adds_socket_class_flag
branch
from
27b8c15 to
b8b9042
Compare
|
@jethrodaniel : Force pushed the socket changes alone to keep the commit history clean |
|
This is a very useful feature IMO. This would allow a socket to be configured beyond the connection timeout, e.g. by binding it to a specific local interface and port. Are there plans to merge this? |
…onnection Ability to add socket_class while instantiating net_ldap connection
|
I merged this into a testing branch to run the CI test suite and got a bunch of failures. I think the best path forward on this would be to rebase the changes onto master and then get the tests passing. Once that's done I can test this with a custom socket class and get this landed. Thanks! Edit: Well GitHub now has a fancy button to easily rebase these changes ontop of master so I went ahead and did that for you so we can see the tests that are failing. I hope you don't mind, but it will affect your branch. |
zeroSteiner
force-pushed
the
adds_socket_class_flag
branch
from
b8b9042 to
dfe625e
Compare
5 participants
No description provided.