Open
Conversation
This would support issue rtCamp#88 - Add support for progress bar.
theMasudRana
previously approved these changes
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Carousel Progress” inner block to Carousel Kit and wires it to Embla’s scroll progress so the editor and frontend can render a progress bar similar to carousel dots.
Changes:
- Introduces a new
carousel-kit/carousel-progressblock (block.json, edit/save, styles). - Tracks
scrollProgressfrom Embla in both the frontend interactivity store and the editor context. - Registers the new block server-side for discovery/loading.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/blocks/carousel/view.ts |
Adds a progress-bar style callback and updates scrollProgress from Embla events. |
src/blocks/carousel/types.ts |
Extends carousel types to include progress block attributes and scrollProgress in CarouselContext. |
src/blocks/carousel/progress/style.scss |
Adds frontend styling for the progress bar. |
src/blocks/carousel/progress/save.tsx |
Adds frontend markup wired to interactivity callbacks. |
src/blocks/carousel/progress/edit.tsx |
Adds editor rendering using EditorCarouselContext. |
src/blocks/carousel/progress/index.ts |
Registers the new progress block. |
src/blocks/carousel/progress/block.json |
Declares the new progress block metadata. |
src/blocks/carousel/editor-context.ts |
Adds scrollProgress to the editor carousel context. |
src/blocks/carousel/edit.tsx |
Subscribes to Embla events to keep editor scrollProgress updated. |
inc/Plugin.php |
Registers the new carousel/progress block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd implement progress bar logic
milindmore22
approved these changes
Apr 2, 2026
milindmore22
left a comment
There was a problem hiding this comment.
Can improved with inline code comments, but overall looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would support issue #88 - Add support for progress bar.