ci: swap Docker trigger-workflow-and-wait for JS workflow_dispatch#64
Draft
stormslowly wants to merge 3 commits into
Draft
ci: swap Docker trigger-workflow-and-wait for JS workflow_dispatch#64stormslowly wants to merge 3 commits into
stormslowly wants to merge 3 commits into
Conversation
convictional/trigger-workflow-and-wait is a Docker container action; on the mini runner there is no Docker daemon, so building its image fails. Replace it with the-actions-org/workflow-dispatch (node20) in both dispatch composite actions. Same wait/fail semantics; the downstream run id is fed to ecosystem-ci-result unchanged.
…e24) node20 is being deprecated and the-actions-org/workflow-dispatch is node20. Use the Codex- two-step (node24): return-dispatch dispatches and returns the run id, await-remote-run polls it to completion. return-dispatch identifies the run by a distinct_id echoed in a step name, so the downstream workflow gains a distinct_id input plus a tiny ubuntu-latest echo job (wired on rspack-ecosystem-ci-from-pr.yml for verification; roll out to the rest once green).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
convictional/trigger-workflow-and-waitis a Docker action, so the dispatch step only runs on Docker-capable Linux runners. Replacing it with the JS-basedCodex-/return-dispatch+Codex-/await-remote-runpair makes the dispatch dockerless (runs on any runner, node24) and returns the downstreamrun_iddirectly.What
ecosystem_ci_dispatch(from-pr) andecosystem_ci_per_commit(from-commit): split the single trigger step into Dispatch (return-dispatch) + Await (await-remote-run), and feed the resultingrun_idintoecosystem-ci-resultand the action outputs.rspack-ecosystem-ci-from-pr.yml: add adistinct_idinput and areturn-dispatch-idjob thatreturn-dispatchneeds to correlate the dispatched run.TODO before ready
ecosystem_ci_dispatch'sreturn-dispatchref:is pinned toci/dockerless-workflow-dispatchfor verification (commitc741cf0) — revert tomainbefore finalize.distinct_idinput +return-dispatch-idjob to the other five stacks' from-pr workflows and all from-commit workflows (cross-stack isomorphism).ecosystem_ci_dispatch/**+ecosystem_ci_per_commit/**→ run the SHA Pin release + consumer pin bump per policy.