Conversation
There was a problem hiding this comment.
Pull request overview
This PR resolves current lint failures by removing TypeScript suppression comments and replacing them with typed alternatives, plus a small cleanup in the client logger plumbing.
Changes:
- Replaced
@ts-ignore/@ts-expect-errorsuppressions with explicit typing/casts and updated an ANSI escape regex to a TS-safe form. - Added local TypeScript module declarations for
@rspack/core/hot/*imports used by the client runtime. - Simplified the client logger implementation by removing unused
getChildLoggerplumbing and tightening a stub hook implementation.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/normalizeOptions.test.ts | Removes TS suppression comments by using a typed cast for snapshot normalization. |
| src/server.ts | Minor refactor (let → const) in client transport selection to satisfy linting/immutability expectations. |
| client-src/utils/ansiHTML.ts | Replaces octal escape sequence with \x1b to avoid TS parsing/lint issues. |
| client-src/rspack-hot.d.ts | Adds minimal local module declarations for rspack HMR emitter/log imports. |
| client-src/modules/logger/Logger.ts | Renames internals to “Rspack” and removes unused child logger wiring. |
| client-src/modules/logger/index.ts | Updates SyncBailHook stub to a class and removes now-unused child logger creation path. |
| client-src/index.ts | Switches to the locally-declared rspack hot log import name and updates usage accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e62569e5ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
This PR fixes the current lint failures by replacing
ts-commentsuppressions with typed alternatives, adding a minimal local declaration for the rspack hot modules, and removing the unusedgetChildLoggerplumbing.Testing
pnpm lintpnpm buildRelated Links