Skip to content

chore: fix mapRslintTemplate comments#139

Merged
chenjiahan merged 3 commits into
mainfrom
fix/rslint-template-fallback
May 14, 2026
Merged

chore: fix mapRslintTemplate comments#139
chenjiahan merged 3 commits into
mainfrom
fix/rslint-template-fallback

Conversation

@elecmonkey
Copy link
Copy Markdown
Member

To be honest, I don’t think the original behavior is improper, but it does not match the comment.

index.ts currently says:

/**
 * Map the template name to the Rslint template name.
 * If not provided, reuses mapESLintTemplate and falls back to 'vanilla-ts'.
 */
mapRslintTemplate?: (

this pr reuses mapESLintTemplate first.

@elecmonkey elecmonkey requested a review from Timeless0911 May 14, 2026 07:30
@Timeless0911
Copy link
Copy Markdown
Member

Timeless0911 commented May 14, 2026

There's no problem with any Rspress template using react-ts tpl of lint tools. Why this change?

@elecmonkey
Copy link
Copy Markdown
Member Author

There's no problem with any Rspress template using react-ts tpl of lint tools. Why this change?

It's no relations to Rspress. comment says mapRslintTemplate will reuses mapESLintTemplate (if not provided) but it actually not.

@Timeless0911
Copy link
Copy Markdown
Member

Oh, it's create-rstack repo. I think we do not need to use mapESLintTemplate as fallback, just falls back to 'vanilla-ts' is enough. @chenjiahan cc

@chenjiahan chenjiahan changed the title fix: reuse eslint mapping for rslint templates chore: fix mapRslintTemplate comments May 14, 2026
@chenjiahan
Copy link
Copy Markdown
Member

I prefer to fix the comment. LGTM

@chenjiahan chenjiahan merged commit 8ac6a25 into main May 14, 2026
4 checks passed
@chenjiahan chenjiahan deleted the fix/rslint-template-fallback branch May 14, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants