Fixed connectionSize Limit#23
Open
AlexStanglEmerson wants to merge 1 commit intorossmann-engineering:masterfrom
Open
Fixed connectionSize Limit#23AlexStanglEmerson wants to merge 1 commit intorossmann-engineering:masterfrom
AlexStanglEmerson wants to merge 1 commit intorossmann-engineering:masterfrom
Conversation
For the T_O_Length, values were limited to 255 due to the byte typecast. However, the connection size parameter is 9 bits long, so the conversion was changed to a UInt16 which also matches the connectionSize variable's datatype.
LucaSala91
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T_O_Length is a UInt16, but when adding it and the t_o_headerOffset variables together to get the connectionSize, it was typecast to a byte. When working with a device that returns 496 bytes, an implicit connection could not be established due to this. The conversion was changed to a UInt16 to allow for all 9 bits.
I think issue #19 may be related to this.