[core] Avoid a clang vectoriser bug in TColorGradient.#22060
Open
hageboeck wants to merge 3 commits intoroot-project:masterfrom
Open
[core] Avoid a clang vectoriser bug in TColorGradient.#22060hageboeck wants to merge 3 commits intoroot-project:masterfrom
hageboeck wants to merge 3 commits intoroot-project:masterfrom
Conversation
The loop vectoriser in clang-20 to clang-22 can overflow the stack, which should explain the crashes observed when mac beta moved to clang-21. Here, we instruct the vectoriser to leave the affected loop untouched. llvm/llvm-project#194008 Fix root-project#21367
This reverts commit 8c25d31. With the fix for root-project#21367, the test is expected to pass again.
This reverts commit 70ad2cb. With the fix for root-project#21367, the tests are expected to pass again.
hageboeck
force-pushed
the
loop_vectoriser_bug
branch
from
132ce99 to
4f3dcc4
Compare
1 task
hageboeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop vectoriser in clang-20 to clang-22 can overflow the stack, which should explain the crashes observed when mac beta moved to clang-21.
Here, we instruct the vectoriser to leave the loop in the affected function untouched.
llvm/llvm-project#194008