Skip to content

[openssl] builtin: destination of include files was not correct#22026

Merged
dpiparo merged 1 commit intoroot-project:masterfrom
ferdymercury:patch-20
Apr 27, 2026
Merged

[openssl] builtin: destination of include files was not correct#22026
dpiparo merged 1 commit intoroot-project:masterfrom
ferdymercury:patch-20

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Apr 23, 2026

Compilation on mac of XRootd and/or civetweb with builtin_openssl probably just worked fine because it picked system-wide openssl headers rather than the builtin ones.

Found out while investigating failures in #21947 of the type
openssl/bn.h not found even if it was correctly doing `include_directories("/Users/sftnight/ROOT-CI/build/builtins/openssl/OPENSSL-prefix/include")
See https://github.com/root-project/root/actions/runs/24824049926/job/72655476462

2026-04-23T08:10:32.7957500Z -- Found OpenSSL: /Users/sftnight/ROOT-CI/build/builtins/openssl/OPENSSL-prefix/lib/libcrypto.a
2026-04-23T08:10:32.7957990Z -- OpenSSL include directory: /Users/sftnight/ROOT-CI/build/builtins/openssl/OPENSSL-prefix/include
2026-04-23T08:10:32.7958410Z CMake Warning at src/CMakeLists.txt:60 (message):
2026-04-23T08:10:32.7958700Z 
2026-04-23T08:10:32.7958740Z  ---> HERE glob returns no headers .h at all in that folder or any subdir

/Users/sftnight/ROOT-CI/build/builtins/CIVETWEB-prefix/src/BUILTIN_CIVETWEB/src/civetweb.c:1751:10: fatal error: 'openssl/bn.h' file not found
2026-04-23T08:10:32.9740120Z  1751 | #include <openssl/bn.h>
2026-04-23T08:10:32.9740590Z       |          ^~~~~~~~~~~~~~

Note that Makefile.in of the openssl repository has extra logic depending on if openssldir is passed or not, and modifies the destination suffixes accordingly.

Compilation with builtin_openssl probably just worked fine because it picked system-wide openssl headers rather than the builtin ones.

Found out while investigating failures in root-project#21947
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Test Results

    22 files      22 suites   3d 8h 51m 53s ⏱️
 3 849 tests  3 847 ✅  1 💤 1 ❌
76 862 runs  76 843 ✅ 18 💤 1 ❌

For more details on these failures, see this check.

Results for commit e3e1e6d.

♻️ This comment has been updated with latest results.

@bellenot bellenot assigned ferdymercury and unassigned bellenot Apr 23, 2026
@ferdymercury ferdymercury added this to the 6.40.00 milestone Apr 24, 2026
@dpiparo dpiparo merged commit 967a2f2 into root-project:master Apr 27, 2026
72 of 76 checks passed
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Apr 27, 2026

/backport to 6.40

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22026 to branch 6.40 requested by dpiparo

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22074

@ferdymercury ferdymercury deleted the patch-20 branch April 27, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants