[core] Update version files and clean up APIs marked for removal.#22023
Open
hageboeck wants to merge 7 commits intoroot-project:masterfrom
Open
[core] Update version files and clean up APIs marked for removal.#22023hageboeck wants to merge 7 commits intoroot-project:masterfrom
hageboeck wants to merge 7 commits intoroot-project:masterfrom
Conversation
dpiparo
approved these changes
Apr 23, 2026
hageboeck
force-pushed
the
deprecation_macros_6.40
branch
from
f074549 to
63582a5
Compare
hageboeck
changed the title
Test Results 21 files 21 suites 3d 7h 6m 19s ⏱️ For more details on these failures, see this check. Results for commit 63582a5. |
pcanal
reviewed
Apr 23, 2026
|
|
||
| /* USE AS `R__DEPRECATED(6,40, "Not threadsafe; use TFoo::Bar().")` | ||
| To be removed by 6.40 */ | ||
| #if ROOT_VERSION_CODE <= ROOT_VERSION(6, 39, 0) |
Member
There was a problem hiding this comment.
Maybe add 6.45 deprecation macro to keep the on-going number to 3.
Member
Author
There was a problem hiding this comment.
We might not make it to v6.46, so adding such a macro might not be useful at the moment.
hageboeck
force-pushed
the
deprecation_macros_6.40
branch
from
63582a5 to
1cbab5a
Compare
Honour the request on the users workshop to keep deprecated interfaces around for longer.
hageboeck
force-pushed
the
deprecation_macros_6.40
branch
from
1cbab5a to
245600b
Compare
These were marked for removal in v6.42
These were marked for removal in v6.42
The removal of authenticated sockets is a non-trivial operation. To allow for incrementing ROOT's version number now, the deprecation macro will only trigger when exceeding version 6.42.01. This ensures that the interface is removed before branching. Furthermore, remove unused macros from past versions.
hageboeck
requested review from
bellenot,
guitargeek and
jblomer
as code owners
hageboeck
force-pushed
the
deprecation_macros_6.40
branch
from
245600b to
3f75aeb
Compare
guitargeek
approved these changes
Apr 27, 2026
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks a lot! LGTM from my side for the RooFit changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removal of authenticated sockets is a bit more time intensive, so it will be performed over the coming days by @jblomer.
In order to be able to increment the version number now, the v6.42 deprecation macro has been altered to trigger only after v6.41.01. This ensures that the authenticated sockets are removed before the next branch point.