Fix argument passing conventions in h2root.#21404
Conversation
|
The other piece of info is that on macOS, the |
When variable-length strings are passed into functions compiled by gfortran, the lengths of the strings have to be passed at the end of the argument list as size_t. When using gcc <= 7 or clang (where the __GNUC__ macro might return unpredictable values), we were putting int on the C side, which got interpreted as size_t on the fortran side.
hageboeck
force-pushed
the
fix_h2root
branch
from
12aa087 to
0ad7fc2
Compare
Test Results 22 files 22 suites 3d 6h 36m 56s ⏱️ For more details on these failures, see this check. Results for commit 0ad7fc2. |
|
/backport to 6.38 |
|
This PR has been backported to branch 6.38: #21410 |
|
/backport to 6.36 6.32 6.30 6.28 |
|
/backport to 6.36, 6.32, 6.30, 6.28 |
|
Preparing to backport PR #21404 to branches 6.36, 6.32, 6.30 and 6.28 requested by hageboeck |
|
Something went wrong with the creation of the PR to backport to 6.32: @hageboeck please see the logs |
|
Something went wrong with the creation of the PR to backport to 6.30: @hageboeck please see the logs |
|
Something went wrong with the creation of the PR to backport to 6.28: @hageboeck please see the logs |
|
This PR has been backported to branch 6.36: #22568 |
4 participants
When variable-length strings are passed into functions compiled by gfortran, the lengths of the strings have to be passed at the end of the argument list as
size_t(since gcc 7). With clang, where the__GNUC__macro could expand to funny values, we were passinginton the C side, making fortran interpret the string lengths wrongly.fixes #19329