[hist] Implement conversion of RVariableBinAxis and RCategoricalAxis
#20984
+158
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 11h 5m 27s ⏱️ Results for commit b9c21dd. ♻️ This comment has been updated with latest results. |
For copying the bins, it is not important which axis type we are copying from, we only need the full index range.
The function will be extended for other axis types and then reused to convert multidimensional histograms.
hahnjo
force-pushed
the
hist-convert-axis
branch
from
a57550a to
b9c21dd
Compare
hageboeck
approved these changes
Jan 29, 2026
Comment on lines
+11
to
+14
| namespace ROOT { | ||
| namespace Experimental { | ||
| namespace Hist { | ||
| namespace Internal { |
| if (auto *regular = src.GetRegularAxis()) { | ||
| dst.Set(regular->GetNNormalBins(), regular->GetLow(), regular->GetHigh()); | ||
| } else { | ||
| throw std::logic_error("unimplemented axis type"); // GCOVR_EXCL_LINE |
Member
There was a problem hiding this comment.
It's hard to trigger this exception, but maybe the message could give more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.