Skip to content

chore(repo): test migration to vitest. phase 2#1976

Merged
shellscape merged 3 commits intomasterfrom
chore/vitest-migration-phase-2
Mar 6, 2026
Merged

chore(repo): test migration to vitest. phase 2#1976
shellscape merged 3 commits intomasterfrom
chore/vitest-migration-phase-2

Conversation

@charliecreates
Copy link
Contributor

@charliecreates charliecreates bot commented Mar 6, 2026

Refs #1974

Summary

Migrated Ava tests to Vitest for phase 2 packages using the shared .config/vitest.config.mts invocation pattern.

Phase 2 packages

  • babel
  • dynamic-import-vars
  • esm-shim
  • html
  • json
  • replace
  • terser
  • url
  • wasm

Validation

  • Package ci:test checks for all phase 2 packages were run locally and passed.
  • pnpm lint:js and pnpm prettier:check were run locally and passed.

@shellscape
Copy link
Collaborator

@CharlieHelps CI is failing with ERR_PNPM_OUTDATED_LOCKFILE. please resolve the issue.

@charliecreates
Copy link
Contributor Author

charliecreates bot commented Mar 6, 2026

@shellscape Fixed. I updated pnpm-lock.yaml to include the dependency graph changes from packages/wasm/package.json, pushed commit 4d029fe to this PR branch, and re-ran pnpm install --frozen-lockfile locally (now passes).

Commit: 4d029fe

@shellscape
Copy link
Collaborator

@CharlieHelps why did you add types-registry to wasm? That dependency wasn't needed previously and it doesn't exist as a string reference in master

@charliecreates
Copy link
Contributor Author

charliecreates bot commented Mar 6, 2026

Good catch — that dependency was accidental from the Vitest migration edit. I’ve removed types-registry from packages/wasm/package.json and cleaned the corresponding lockfile entries in 9013f9f. I also re-ran pnpm --filter @rollup/plugin-wasm test and pnpm --filter @rollup/plugin-wasm test:ts; both pass without it.

@shellscape shellscape merged commit 16b7339 into master Mar 6, 2026
5 checks passed
@shellscape shellscape deleted the chore/vitest-migration-phase-2 branch March 6, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants