Skip to content

chore(terser)!: upgrade serialize-javascript to v7 and node to v20 #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shellscape merged 2 commits into from
Mar 5, 2026
+16 −24
Merged

chore(terser)!: upgrade serialize-javascript to v7 and node to v20 #1968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e8970
chore(deps)!: upgrade serialize-javascript to v7 and node to v20
dargmuesli Mar 1, 2026
7132550
ci: upgrade node versions to non-end of life
dargmuesli Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
node: ['20', '18']
node: ['24', '20']
Copy link

@stof stof Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also include 22 ?

Copy link
Contributor Author

@dargmuesli dargmuesli Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want an explicit for it, yes. If you just wanna check bounds, this could be sufficient. Comes down to being entirely sure or limiting resource usage and saving some of the planet as a trade off.

Copy link
Collaborator

@shellscape shellscape Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I'm good with this. honestly we really only need to be testing the latest, since node does really good back compat, but fine with this


name: Node v${{ matrix.node }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
node: ['20', '18']
node: ['20', '24']

name: Node v${{ matrix.node }}

Expand Down
6 changes: 3 additions & 3 deletions packages/terser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"default": "./dist/cjs/index.js"
},
"engines": {
"node": ">=14.0.0"
"node": ">=20.0.0"
},
"scripts": {
"build": "rollup -c",
Expand Down Expand Up @@ -61,12 +61,12 @@
}
},
"dependencies": {
"serialize-javascript": "^6.0.1",
"serialize-javascript": "^7.0.3",
"smob": "^1.0.0",
"terser": "^5.17.4"
},
"devDependencies": {
"@types/serialize-javascript": "^5.0.2",
"@types/serialize-javascript": "^5.0.4",
"rollup": "^4.0.0-24",
"typescript": "^4.8.3"
},
Expand Down
30 changes: 11 additions & 19 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading