Adding ability to set the dns policy and config for the runner pod

[andrewgkew]

Currently the helm chart is missing the capability to set the DNS Policy and DNS Config of the runner pod

Adding this ability. By default its turned off and defaults to ClusterFirst which is the default value for this field if this doesnt exist

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7894665-603d-458d-8cf3-7e2dd1b84584

📥 Commits

Reviewing files that changed from the base of the PR and between 393926d and 8d5b605.

📒 Files selected for processing (2)

• helm/robusta/templates/runner.yaml
• helm/robusta/values.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• helm/robusta/values.yaml

---

Walkthrough

The Helm chart adds a new runner.dnsConfig values block and updates the runner Pod template to render dnsPolicy from that block. When runner.dnsConfig.enabled is true, the template conditionally includes a dnsConfig subsection populated from nameservers, searches, and options; if disabled, dnsPolicy is set to ClusterFirst. A Helm-time validation prevents dnsPolicy: None without any DNS entries.

Changes

Cohort / File(s)	Summary
DNS configuration for runner Pod helm/robusta/templates/runner.yaml, helm/robusta/values.yaml	Adds runner.dnsConfig (fields: enabled, policy, nameservers, searches, options) to values. Template now renders dnsPolicy from runner.dnsConfig.policy, conditionally includes dnsConfig blocks when enabled and entries exist, and validates that dnsPolicy: "None" is not set without nameservers/searches/options. When disabled, dnsPolicy defaults to ClusterFirst.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding DNS policy and config configuration to the runner pod in the Helm chart.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the missing capability and how the feature was implemented with sensible defaults.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@helm/robusta/templates/runner.yaml`:
- Around line 45-58: The dnsConfig block is being emitted at the wrong YAML
level: when .Values.runner.dnsConfig.enabled is true, ensure you output a
top-level dnsConfig: mapping and nest dnsPolicy, nameservers, searches, and
options under it; update the template in runner.yaml to render a single
dnsConfig: key (using .Values.runner.dnsConfig) and then conditionally render
dnsPolicy and the three child lists (nameservers, searches, options) indented
under dnsConfig so the Kubernetes Pod spec is valid.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1d3a11c-1d53-46db-8820-11c1eaef623e

📥 Commits

Reviewing files that changed from the base of the PR and between b147fb8 and 3c551e0.

📒 Files selected for processing (2)

• helm/robusta/templates/runner.yaml
• helm/robusta/values.yaml

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@helm/robusta/templates/runner.yaml`:
- Around line 47-59: The template emits a bare `dnsConfig:` key when all
sub-lists are empty; wrap the entire dnsConfig block with a guard that checks
whether any of .Values.runner.dnsConfig.nameservers,
.Values.runner.dnsConfig.searches, or .Values.runner.dnsConfig.options are
non-empty (use an {{- if or ... }} / {{- end }} around the dnsConfig: stanza) so
dnsConfig is omitted entirely when all three are empty; reference the existing
dnsConfig:, .Values.runner.dnsConfig.nameservers,
.Values.runner.dnsConfig.searches, and .Values.runner.dnsConfig.options symbols
when implementing the guard.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aea6b190-1f80-4075-ad73-f643cc4939d2

📥 Commits

Reviewing files that changed from the base of the PR and between 3c551e0 and 393926d.

📒 Files selected for processing (1)

• helm/robusta/templates/runner.yaml