Conversation
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:e8fc3e3
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:e8fc3e3 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e8fc3e3
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e8fc3e3Patch Helm values in one line: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:e8fc3e3 |
WalkthroughThe Dockerfile is updated to use Kubernetes v1.35 release key and repository, replacing v1.33 references. Changes include updating the curl download URL for the Release.key and the deb source line for kubectl installation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Line 14: Centralize the Kubernetes channel/version by defining a single build
ARG (e.g., K8S_CHANNEL or KUBECTL_VERSION) and replace the hardcoded "v1.35" in
the RUN curl that fetches Release.key and any other references with that ARG;
also pin the kubectl package by installing a specific version (use the same
KUBECTL_VERSION ARG) instead of an unpinned apt install, updating the apt
repository entry and the installation command (refer to the RUN that fetches
Release.key and the RUN/apt-get step that installs kubectl) so builds are
deterministic and the channel/version is maintained in one place.
- Around line 94-96: Install kubectl with an explicit package version instead of
unpinned apt-get install -y kubectl to ensure reproducible builds; change the
apt install invocation that references kubectl in the Dockerfile to install a
specific package version (for example use version string like 1.35.2-1.1) and
update any related apt key/source logic accordingly. After building, verify the
kubectl binary was built with a Go runtime patched for the TLS CVE by running
kubectl version --client -o yaml and confirming the Go version is >=1.24.13 or
>=1.25.7 (or consult kubectl release notes), and record the pinned kubectl
version in build metadata for audits.
No description provided.