Skip to content

fix(transformer.py): fpdf2 doesn't accept more than 1 positional arg#2019

Merged
arikalon1 merged 2 commits intorobusta-dev:masterfrom
wardVD:patch-1
Mar 11, 2026
Merged

fix(transformer.py): fpdf2 doesn't accept more than 1 positional arg#2019
arikalon1 merged 2 commits intorobusta-dev:masterfrom
wardVD:patch-1

Conversation

@wardVD
Copy link
Contributor

@wardVD wardVD commented Feb 27, 2026

This should fix #2005

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5ed072 and 9780ac7.

📒 Files selected for processing (1)
  • src/robusta/core/sinks/transformer.py

Walkthrough

Modified the PDF output method call in the write_table function by removing the explicit string output mode arguments from pdf.output(), changing from pdf.output("", "S") to pdf.output(). This alters how PDF data is generated and passed to FileBlock.

Changes

Cohort / File(s) Summary
PDF Output Configuration
src/robusta/core/sinks/transformer.py
Modified PDF generation in write_table by changing pdf.output("", "S") to pdf.output(), removing explicit string output mode specification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing an fpdf2 compatibility issue with positional arguments in transformer.py.
Description check ✅ Passed The description references issue #2005, which is related to the changeset and provides context for the fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JulienOrain
Copy link

hello @wardVD
could you sign the CLA please ?
Thanks

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wardVD

@arikalon1 arikalon1 merged commit 76d1553 into robusta-dev:master Mar 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Slack Sink] KRR scan reports fail to send to Slack with PDF generation error

4 participants