Open
Conversation
- Fixed a couple incorrectly modified type hints on click button and click image - Added type hints to get webelement(s) keywords
With using the type union syntax we will require atleast Python 3.10. Also v3.8 and v3.9 have reached end of life.
The `Get Cookies` test started to fail. It was written to expect just the another and test cookies but was also receiving the far_future cookie. I'm a bit unsure as to why this wasn't failing sooner. I would have expected this cookie to also appear. So not sure what was happening here. Git blame shows this has been unchanged for a while. I have updated the expected return value from get cookies. I do see some possible improvements. The previous check allowed for the order to be swapped. With three that is a bit more complicated. Instead of going into a complex check for any order I am going to leave this till we see that appear.
aaltat
approved these changes
Apr 6, 2026
yuriverweij
requested changes
Apr 6, 2026
yuriverweij
approved these changes
Apr 7, 2026
aaltat
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reowrked previous solution to fix cascading locators with this using Type Alias instead of modifying the individual types at each usage of locator.
This solution's syntax requires a minimum Python version of 3.10.