feat: update banners for credit based trial plan#9404
Conversation
djbarnwal
left a comment
There was a problem hiding this comment.
Developed the below feedback with Codex:
-
[P1] Dismissing the welcome banner hides later low-credit warnings forever.
web-admin/src/features/billing/issues/getMessageForTrialPlan.ts:105and:110both usebuildDismissableForIssue, which storesid: issue.typeat:150. Since welcome and low-credit are bothBILLING_ISSUE_TYPE_ON_CREDIT_TRIAL, a forever dismissal from the welcome state makesisBannerDismissedreturn true later atweb-common/src/components/banner/banner-dismiss.ts:16-17. Admins who dismiss “Welcome to Rill” will never see the 80% warning. -
[P1] The 50% and 90% credit flows are not implemented.
getMessageForCreditsTrialonly branches ononCreditTrial.lowCreditatweb-admin/src/features/billing/issues/getMessageForTrialPlan.ts:101. The API shape only exposescreditAllocationandlowCredit(web-admin/src/client/gen/index.schemas.ts:187-191), so the UI cannot show the 50% blue weekly banner or the 90% red “almost out” banner with 4-hour/session dismissal.
Feel free to ignore them if they are not relevant to this PR.
|
Thanks @djbarnwal . Fixed the issue with low credits, good catch. We are not doing 50% & 90% right now, just 80%. Updated the doc to clarify. |
6cbf798 to
067dd7e
Compare
|
Merging since the test is unrelated and on main. |
Updates the banners to support the new credit based trial plan. Follows: https://www.notion.so/rilldata/Cloud-First-Burn-Down-Plan-343ba33c8f57813fb3abdc4e4bcaf042?source=copy_link#34aba33c8f578023b0fffeb698b52304
Checklist: