fix(wal): increment next_segment_id before creating a new segment#1
Open
mangerle wants to merge 1 commit into
Open
fix(wal): increment next_segment_id before creating a new segment#1mangerle wants to merge 1 commit into
mangerle wants to merge 1 commit into
Conversation
mangerle
commented
Jun 22, 2026
mangerle
commented
- Snapshot and increment next_segment_id before creating a new segment
- Unlikely to trigger in practice, but the lazy-init path leaves a latent bug that should be fixed
- For consistency with the rollover logic below, consider the trade-off: if segment creation fails, next_segment_id should not be incremented
- Snapshot and increment next_segment_id before creating a new segment - Unlikely to trigger in practice, but the lazy-init path leaves a latent bug that should be fixed - For consistency with the rollover logic below, consider the trade-off: if segment creation fails, next_segment_id should not be incremented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.