Fix rewatch warning replay after early compile errors

[cknitt]

Summary

Fixes warning replay after an early rewatch compile error.

When the DAG scheduler hits a compile error, it stops dispatching new modules. Some modules can still be in the compile universe but never actually compile. Before this change, warning replay used membership in the compile universe as the skip condition, so stored warnings on those unscheduled modules were skipped.

This change tracks the modules that actually compiled and replays warnings for the ones that did not. It also emits fresh and replayed warnings through one sorted path, so diagnostic output stays deterministic.

Changes

• Track modules that actually compiled, while keeping stored warnings available for modules that were skipped or short-circuited.
• Emit fresh and replayed warnings through one deterministic module-name-sorted path.
• Add regression tests for skipped-module warning replay and mixed fresh/replayed warning ordering.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8408

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8408

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8408

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8408

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8408

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8408

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8408

commit: a922808

[cknitt]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf3418edb4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[cknitt]

@codex review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.10%. Comparing base (892d3aa) to head (a922808).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8408      +/-   ##
==========================================
+ Coverage   58.78%   59.10%   +0.32%     
==========================================
  Files         373      373              
  Lines       54210    54210              
==========================================
+ Hits        31865    32040     +175     
+ Misses      22345    22170     -175     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cknitt]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".