Open
Conversation
Member
|
this broke the version dropdown |
Cloudflare deploymentDeployement ID: ff01d9b8-1b4b-490e-8de4-1303833ffca1 ⛅️ wrangler 4.63.0 (update available 4.66.0) ✨ Uploading _redirects |
Collaborator
Author
Fixed and I added a unit test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the navbar to not be so brittile and depend on checking height for layouts. The main change is using the modern html
dialogcomponent for the mobile menus and switching the header to usestickyto stay in place. Now the content body doesn't need to add margin or padding to account for any headers, they just show up above and can stack easily.There will be some more refactors soon to split up the mdx route, but one thing at a time.
AI summary
This pull request introduces significant improvements to the navigation and documentation layout, particularly around the API and documentation pages. It adds new responsive navigation bar tests, refactors and enhances the tertiary navbar and sidebar for API and docs routes, and automates the management of Vitest screenshot updates. Additionally, it updates the routing and configuration for better scalability and maintainability.Navigation and Layout Enhancements:
NavbarSecondaryandNavbarTertiarycomponents across API and documentation routes, providing consistent breadcrumbs, sidebar content, and edit links for improved user navigation and editing experience. The sidebar now adapts based on route and viewport, supporting mobile drawer toggling and version selection. (app/routes/ApiRoute.res,app/routes/MdxRoute.res,app/routes/SyntaxLookupRoute.res, [1] [2] [3] [4] [5] [6]app/root.res, [1] [2]Testing and Automation Improvements:
NavbarPrimaryandNavbarTertiary, covering desktop, tablet, and mobile scenarios, including screenshot assertions for visual regression testing. (__tests__/NavbarPrimary_.test.res,__tests__/NavbarTertiary_.test.res, [1] [2].github/workflows/pull-request.yml, [1] [2]Routing and Configuration Updates:
mdxRoutesand streamlining their inclusion, and added support for a new "guide" section in the markdown and routing configuration. (app/routes.res,react-router.config.mjs, [1] [2] [3]package.json,rescript.json, [1] [2]Component and Internal Refactoring:
ApiDocs.SidebarTreeandRightSidebarcomponents to remove unused props and streamline sidebar rendering logic. (src/ApiDocs.res, [1] [2]Miscellaneous:
functions/ogimage/[[path]]/index.png.res, functions/ogimage/[[path]]/index.png.resL19-L20)__tests__/Example.test.res, tests/Example.test.resL1-L28)