feat: add rb ffprobe command#107
Draft
a-essawy wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
rb ffprobe [flags] <url-or-file>for probing media metadata in the cloud, mirroringrb ffmpeg's structure (auth flow, StepRenderer spinner, error handling, data-only output rendering) but simplified for a fast, data-only job: it usesclient.jobs.wait()directly instead of the WebSocket/machine-context ceremonyrb ffmpegneeds for longer renders.rb ffmpeg).--keyframes,--raw,--json,--quiet,--no-wait,--timeout N(clamped to 900s).result.output.data.summarypretty-printed to stdout (pipeable tojq).--rawprints the fulloutput.data(format/streams/chapters).--jsonprints the full job result.src/registry.tsunder the CORE group.jobs.create/jobs.waitare generic over the string job type in the currently-published@rendobar/sdk.Notes
ffprobejob type is not live in prod yet — this command will error (job type not found) until rendobar/rendobar#349 ships. Do not merge this before that lands.Test plan
pnpm test— 149 tests pass (includes newffprobe-command.test.tscovering flag parsing, url-vs-local detection, timeout clamping, and the local-upload reuse path — no network calls)pnpm typecheck— cleanpnpm build— compiles; smoke-testedrb ffprobe(empty-args help),rb ffprobe --help, and the unauthenticated error path locally