Skip to content

Added list as an alias for ls#161

Open
wcravens wants to merge 1 commit into
remenoscodes:mainfrom
wcravens:153-add-list-as-alias-to-ls
Open

Added list as an alias for ls#161
wcravens wants to merge 1 commit into
remenoscodes:mainfrom
wcravens:153-add-list-as-alias-to-ls

Conversation

@wcravens
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@remenoscodes remenoscodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this — the symlink approach is clean and keeps the dispatcher pattern consistent.

A few small changes needed:

  1. Commit message: This project uses Conventional Commits for automated changelog generation. Please update to:

    feat: add list as alias for ls
    
  2. PR description: Could you add a brief body? Even a one-liner like "Adds list as an alias for ls per #" helps with the changelog and traceability.

  3. Symlink trailing newline: bin/git-issue-list is missing a trailing newline — POSIX convention is for text files to end with one. You can fix with:

    printf 'git-issue-ls\n' > bin/git-issue-list
    ln -sf git-issue-ls bin/git-issue-list

    (Actually the symlink itself doesn't need it since it's not a text file — disregard this point, symlinks are fine as-is.)

Code-wise this is good to go. Just the commit message and PR description, then we can merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants