Skip to content

docs(DOC-732): document partition_autobalancing_node_autodecommission_time#1607

Open
mfernest wants to merge 2 commits intomainfrom
feat/doc-732-ghost-node-autodecommission
Open

docs(DOC-732): document partition_autobalancing_node_autodecommission_time#1607
mfernest wants to merge 2 commits intomainfrom
feat/doc-732-ghost-node-autodecommission

Conversation

@mfernest
Copy link

@mfernest mfernest commented Mar 16, 2026

Summary

Documents the new partition_autobalancing_node_autodecommission_time cluster property introduced in PR #28946 (CORE-7111).

  • Cluster properties reference: adds the new property entry after partition_autobalancing_node_availability_timeout_sec
  • Continuous Data Balancing guide: adds the property to the configuration table with a clear explanation of how it differs from the availability timeout (permanent decommission vs. partition moves)

Key points documented:

  • Opt-in (null/disabled by default)
  • Only applies when partition_autobalancing_mode is continuous
  • Permanently removes the node — unlike availability_timeout_sec, the node cannot rejoin
  • One decommission at a time; stalled decommissions require manual intervention

SME: Joe Miller

Preview

Test plan

  • Netlify deploy preview passes
  • Property entry renders correctly in cluster properties reference
  • Continuous data balancing table renders correctly

🤖 Generated with Claude Code

…_time

Add new cluster property that enables automatic decommission of
unavailable nodes after a configurable timeout. Updates both the
cluster properties reference and the continuous data balancing guide.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mfernest mfernest requested a review from a team as a code owner March 16, 2026 18:20
@netlify
Copy link

netlify bot commented Mar 16, 2026

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 05fa6f5
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/69b84f71b6e302000831681d
😎 Deploy Preview https://deploy-preview-1607--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c050be3e-b9a7-41ab-8328-357bf3d29550

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Two documentation files were updated to introduce a new cluster property partition_autobalancing_node_autodecommission_time. The property specifies a timeout in seconds for automatic node decommission when using continuous data balancing mode. Documentation includes the property's type, default state (disabled), behavior notes, and distinction from related properties. Updates maintain consistency across continuous data balancing and cluster properties reference documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • mattschumpert
  • wdberkeley
  • micheleRP
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the key information but is missing required template sections like Jira ticket link, review deadline, and checkbox selections. Add the missing template sections: include the Jira ticket URL in the Description header, specify a review deadline, and check the appropriate category box (likely 'Content gap' or 'New feature').
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: documenting a new cluster property with specific reference to the JIRA ticket.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/doc-732-ghost-node-autodecommission
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
modules/manage/pages/cluster-maintenance/continuous-data-balancing.adoc (1)

30-30: Minor phrasing improvement (optional).

The phrase "at least this timeout duration" is slightly awkward. Consider simplifying to "for this timeout duration" since the "at least" is implied by a timeout.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/manage/pages/cluster-maintenance/continuous-data-balancing.adoc` at
line 30, Update the sentence describing the decommission timeout in
continuous-data-balancing.adoc: replace the phrase "at least this timeout
duration" with "for this timeout duration" to simplify phrasing; keep the rest
of the sentence and references to the property
partition_autobalancing_node_availability_timeout_sec unchanged so the meaning
remains that a node unavailable for this timeout is permanently decommissioned.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@modules/manage/pages/cluster-maintenance/continuous-data-balancing.adoc`:
- Around line 29-34: The description for
partition_autobalancing_node_autodecommission_time is missing the unit and
prerequisite context: update the prose to state the unit is seconds (e.g.,
"measured in seconds") and add a sentence clarifying this property only applies
when partition_autobalancing_mode is set to continuous; also keep the existing
notes about default null/disabled, one-node-at-a-time behavior, and manual
intervention if decommission stalls so the table matches other properties'
phrasing and the PR objectives.

---

Nitpick comments:
In `@modules/manage/pages/cluster-maintenance/continuous-data-balancing.adoc`:
- Line 30: Update the sentence describing the decommission timeout in
continuous-data-balancing.adoc: replace the phrase "at least this timeout
duration" with "for this timeout duration" to simplify phrasing; keep the rest
of the sentence and references to the property
partition_autobalancing_node_availability_timeout_sec unchanged so the meaning
remains that a node unavailable for this timeout is permanently decommissioned.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2438c28d-c101-4515-b05e-1eacf4a7de5a

📥 Commits

Reviewing files that changed from the base of the PR and between fe8a357 and 8129884.

📒 Files selected for processing (2)
  • modules/manage/pages/cluster-maintenance/continuous-data-balancing.adoc
  • modules/reference/partials/properties/cluster-properties.adoc

@mfernest mfernest requested a review from joe-redpanda March 16, 2026 18:42
…roperty

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
+
Default is 900 seconds (15 minutes).

| `partition_autobalancing_node_autodecommission_time`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partition_autobalancing_node_autodecommission_timeout_sec

This got updated down the line to reflect units

| `partition_autobalancing_node_autodecommission_time`
| When a node is unavailable for this timeout duration (in seconds), Redpanda automatically and permanently decommissions the node. This property only applies when `partition_autobalancing_mode` is set to `continuous`. Unlike `partition_autobalancing_node_availability_timeout_sec`, which moves partitions while keeping the node in the cluster, this property removes the node from the cluster entirely. A decommissioned node cannot rejoin the cluster. +
+
Only one node is decommissioned at a time. If a decommission is already in progress, automatic decommission does not trigger until it completes. If the decommission stalls (for example, because the node holds the only replica of a partition), manual intervention is required. +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth cross-linking to node-wise recovery here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants