Lombok agent doesn't need to be configured if javac is enabled

[snjeza]

No description provided.

[testforstephen]

The flag "java.jdt.ls.javac.enabled" only controls whether to delegate compilation and DOM AST to javac, which does not need an additional lombok agent. However, if code completion continues to rely on the ECJ-based engine, the Lombok agent will still be required.

Therefore, the lombok agent is not needed only when both "java.jdt.ls.javac.enabled" and "java.completion.engine": "dom" settings are enabled.

[rgrunber]

What about SourceIndexer.DOM_BASED_INDEXER ? Lombok is affect by source references right ?

Update: Could we just create a separate setting for the dom based indexing as well ? Then just update the instructions for the extra features : https://github.com/redhat-developer/vscode-java/wiki/Javac%E2%80%90based-compilation-support

[snjeza]

Therefore, the lombok agent is not needed only when both "java.jdt.ls.javac.enabled" and "java.completion.engine": "dom" settings are enabled.
What about SourceIndexer.DOM_BASED_INDEXER ? Lombok is affect by source references right ?

Fixed.

[rgrunber]

The issue is we don't even set the dom based indexer at

vscode-java/src/javaServerStarter.ts

Lines 143 to 145 in 2f57115

	if('dom' === getJavaConfiguration().get('completion.engine')){
	params.push('-DCompilationUnit.codeComplete.DOM_BASED_OPERATIONS=true');
	};

so I meant we need a separate setting for it as well.