chore(x2a): job-script gitignore issues#3436
Conversation
yray-pixel
requested review from
a team,
elai-shalev,
eloycoto and
mareklibra
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
eloycoto
left a comment
eloycoto
left a comment
There was a problem hiding this comment.
congrats on your first PR in 🎉
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
==========================================
+ Coverage 52.43% 53.57% +1.14%
==========================================
Files 2251 2250 -1
Lines 85725 85740 +15
Branches 24111 24129 +18
==========================================
+ Hits 44948 45936 +988
- Misses 39164 39513 +349
+ Partials 1613 291 -1322
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM, please just add changeset.
In the workspaces/x2a call yarn changeset. Then choose just the x2a-backend plugin and patch level. Write a short comment there.
Git add the newly created file.
These changesets are used for both the CHANGELOG files and triggering release.
|
3 participants
Fixes FLPATH-4383
Problem
When source/target repositories have
.gitignorerules blocking files likemigration-plan.md, the x2a job scriptwould create these files but silently fail to commit them to the target repository.
Solution
Add detection and logging for files that exist but weren't committed due to
.gitignorerules:git ls-files --others --ignored --exclude-standardto find gitignored files in PROJECT_DIRTesting
✅ Tested with repos containing
*.mdin.gitignore✅ Verified warnings appear for gitignored files
✅ Verified normal files still commit correctly
✅ Verified empty PROJECT_DIR doesn't cause errors
Changes
cleanup()function