Skip to content

fix(extensions): fixed missing type definition file for jest#2990

Open
debsmita1 wants to merge 2 commits intoredhat-developer:mainfrom
debsmita1:fix-missing-jest
Open

fix(extensions): fixed missing type definition file for jest#2990
debsmita1 wants to merge 2 commits intoredhat-developer:mainfrom
debsmita1:fix-missing-jest

Conversation

@debsmita1
Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

Resolves:
https://redhat.atlassian.net/browse/RHDHBUGS-3064

Solution description:

Added @types/jest to the workspaces/extensions root devDependencies

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.67%. Comparing base (3dfbbee) to head (1508d9c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   60.73%   60.67%   -0.07%     
==========================================
  Files        2065     2058       -7     
  Lines       63737    63572     -165     
  Branches    16619    16595      -24     
==========================================
- Hits        38710    38571     -139     
+ Misses      23780    23579     -201     
- Partials     1247     1422     +175     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 1a0ed2f
ai-integrations 69.58% <ø> (ø) Carriedforward from 1a0ed2f
app-defaults 69.60% <ø> (ø) Carriedforward from 1a0ed2f
augment 69.36% <ø> (ø) Carriedforward from 1a0ed2f
bulk-import 72.58% <ø> (+0.15%) ⬆️ Carriedforward from 1a0ed2f
cost-management 16.49% <ø> (ø) Carriedforward from 1a0ed2f
dcm 32.85% <ø> (ø) Carriedforward from 1a0ed2f
extensions 61.42% <ø> (ø)
global-floating-action-button 73.75% <ø> (ø) Carriedforward from 1a0ed2f
global-header 61.53% <ø> (-0.09%) ⬇️ Carriedforward from 1a0ed2f
homepage 50.84% <ø> (ø) Carriedforward from 1a0ed2f
konflux 91.01% <ø> (ø) Carriedforward from 1a0ed2f
lightspeed 69.64% <ø> (ø) Carriedforward from 1a0ed2f
mcp-integrations 81.59% <ø> (ø) Carriedforward from 1a0ed2f
orchestrator 33.08% <ø> (+0.01%) ⬆️ Carriedforward from 1a0ed2f
quickstart 62.64% <ø> (ø) Carriedforward from 1a0ed2f
sandbox 79.56% <ø> (ø) Carriedforward from 1a0ed2f
scorecard 83.23% <ø> (-0.38%) ⬇️ Carriedforward from 1a0ed2f
theme 64.54% <ø> (ø) Carriedforward from 1a0ed2f
translations 8.49% <ø> (ø) Carriedforward from 1a0ed2f
x2a 82.09% <ø> (ø) Carriedforward from 1a0ed2f

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfbbee...1508d9c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@debsmita1 debsmita1 force-pushed the fix-missing-jest branch from 917e7c1 to 1a0ed2f Compare May 4, 2026 13:51
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is the correct fix. It seems that this workspace doesn't even depend on jest itself, so adding @types/jest seems strange, where is the regular dependency coming from?

@nickboldt
Copy link
Copy Markdown
Member

See also backstage/community-plugins#7868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants