test(lightspeed): add Playwright e2e for notebooks#2983
Open
HusneShabbir wants to merge 5 commits intoredhat-developer:mainfrom
Open
test(lightspeed): add Playwright e2e for notebooks#2983HusneShabbir wants to merge 5 commits intoredhat-developer:mainfrom
HusneShabbir wants to merge 5 commits intoredhat-developer:mainfrom
Conversation
Add coverage for fullscreen notebooks chrome, onboarding, document modal, sidebar collapse, YAML upload/remove, and rename/delete lifecycle. Provide shared e2e helpers and a sample YAML fixture. Enable notebooks in workspace app-config for the e2e webServer while keeping model and provider placeholders for env-based configuration. Co-authored-by: Cursor <cursoragent@cursor.com>
HusneShabbir
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
github-actions
Bot
added
workspace/lightspeed
and removed
do-not-merge/work-in-progress
labels
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
========================================
Coverage 60.56% 60.57%
========================================
Files 2005 2005
Lines 62788 62807 +19
Branches 16360 16368 +8
========================================
+ Hits 38030 38047 +17
- Misses 23352 23457 +105
+ Partials 1406 1303 -103
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
- Add NotebookSurfacePage and focused modal/dialog page objects.\n- Align JA document-count assertion with NotebookCard copy (notebooks.documents).\n- Flatten notebooks spec and shorten test titles.\n- Consolidate notebook fixtures/helpers; drop unused YAML stubs. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add fixtures for 11-file cap, unsupported type, and bulk JSON set.\n- Add NotebookOverwriteConfirmModalPage; extend upload modal/surface page helpers.\n- Cover too-many-files and unsupported-type alerts using LightspeedMessages + substituteNotebookTemplate. Co-authored-by: Cursor <cursoragent@cursor.com>
Use explicit notebook model and provider values in lightspeed notebooks queryDefaults instead of unresolved env placeholders. Co-authored-by: Cursor <cursoragent@cursor.com>
Use test.describe.configure({ mode: 'serial' }) so ordered steps share one page and failures skip the rest of the group.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add coverage for fullscreen notebooks chrome, onboarding, document modal, sidebar collapse, YAML upload/remove, and rename/delete lifecycle. Provide shared e2e helpers and a sample YAML fixture.
Enable notebooks in workspace app-config for the e2e webServer while keeping model and provider placeholders for env-based configuration.
Hey, I just made a Pull Request!
✔️ Checklist