feat(auth-provider): initialize auth-providers workspace#2860
feat(auth-provider): initialize auth-providers workspace#2860JessicaJHee wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
JessicaJHee
requested review from
a team,
christoph-jerolimov and
rohitkrai03
as code owners
Code Review by Qodo
1. Hard-requires auth.providers
|
|
This pull request adds a new top-level directory under |
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Review Summary by QodoAdd Keycloak and PingFederate OIDC authentication providers with RHDH-specific resolvers
WalkthroughsDescription• Adds Keycloak and PingFederate OIDC authentication providers with RHDH-specific sign-in resolvers • Implements backend module with configurable sign-in resolver factories for both providers • Extends frontend sign-in page with Keycloak and PingFederate provider support • Creates new auth-providers workspace with OIDC provider plugin infrastructure Diagramflowchart LR
A["Auth Providers Workspace"] --> B["Backend OIDC Module"]
B --> C["Keycloak Provider Factory"]
B --> D["PingFederate Provider Factory"]
C --> E["Sign-in Resolvers"]
D --> E
E --> F["oidcSubClaimMatching"]
E --> G["oidcLdapUuidMatching"]
E --> H["preferredUsernameMatching"]
I["Frontend Auth APIs"] --> J["Keycloak Auth API"]
I --> K["PingFederate Auth API"]
J --> L["Sign-in Page"]
K --> L
L --> M["Provider-specific Titles"]
File Changes1. workspaces/auth-providers/plugins/auth-backend-module-rhdh-oidc-provider/src/index.ts
|
rhdh-qodo-merge
Bot
added
documentation
JessicaJHee
force-pushed
the
auth-provider-ws
branch
4 times, most recently
from
c8ea415 to
8906491
Compare
JessicaJHee
changed the title
JessicaJHee
force-pushed
the
auth-provider-ws
branch
from
8906491 to
1be8b26
Compare
kim-tsao
left a comment
kim-tsao
left a comment
There was a problem hiding this comment.
Can we also update the CODEOWNERS file?
JessicaJHee
force-pushed
the
auth-provider-ws
branch
from
1be8b26 to
9ad7bc1
Compare
|
|
Usually a workspace has a backstage app instance for local dev and e2e test purposes, and can probably be helpful for example usage, would one make sense here? |
We definitely could, but I'm thinking it makes more sense to pull this into RHDH by installing it as a dynamic plugin since we need to use it with the NFS with |
hopehadfield
left a comment
hopehadfield
left a comment
There was a problem hiding this comment.
I left a couple comments, but other than that it looks good to me!
There was a problem hiding this comment.
I would think about adding a short description here for quick reference
Signed-off-by: Jessica He <jhe@redhat.com> Co-authored-by: Hope Hadfield <hhadfiel@redhat.com>
JessicaJHee
force-pushed
the
auth-provider-ws
branch
from
f5f266e to
9b94e98
Compare
|
hopehadfield
left a comment
hopehadfield
left a comment
There was a problem hiding this comment.
Haven't reviewed the plugin content itself, but from a new workspace standpoint everything seems to be in order. LGTM
|
Holding off on merging this for now while I investigate the option to contribute this upstream to community-plugins |
4 participants
Hey, I just made a Pull Request!
Adds Keycloak and PingFederate authentication providers with RHDH-specific sign-in resolvers and frontend support
In the new auth-providers workspace:
auth-backend-module-rhdh-oidc-provideroidcSubClaimMatchingKeycloakUserIdas default resolveroidcLdapUuidMatchingAnnotationas default resolverpreferredUsernameMatchingUserEntityName,oidcSubClaimMatchingPingIdentityUserIdIn
app-auth: Register Keycloak and PingFederate auth API factories and add sign-in page entries for Keycloak and PingFederateFixes RHIDP-11787
Breaking Changes when installed in RHDH
<provider-id> is not configured to support sign-in✔️ Checklist
Testing Notes
After installing
app-auth,app-integrations, andauth-backend-module-rhdh-oidc-provideras dynamic plugins in RHDH, run in root:ENABLE_AUTH_PROVIDER_MODULE_OVERRIDE=true yarn start:next --env-mode=loose